enhancement(observability): Add _utilization_mean buffer metrics
#24453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source and transform buffer utilization metrics currently measure either the instantaneous level or a histogram, neither of which is a reliable single-valued reflection of the actual status. For this purpose, we introduce a `mean` metric that uses the EWMA calculations to produce a simple moving average that will better track the actual value.
bruceg
added
type: enhancement
github-actions
bot
added
domain: sinks
maycmlee
reviewed
Jan 7, 2026
Contributor
maycmlee
left a comment
maycmlee
left a comment
There was a problem hiding this comment.
Just a couple of small suggestions
maycmlee
approved these changes
Jan 7, 2026
thomasqueirozb
approved these changes
Jan 8, 2026
Comment on lines
+165
to
+176
| let mut result = f64::NAN; | ||
| self.average | ||
| .fetch_update(Ordering::Relaxed, Ordering::Relaxed, |current| { | ||
| let average = if current.is_nan() { | ||
| point | ||
| } else { | ||
| point.mul_add(self.alpha, current * (1.0 - self.alpha)) | ||
| }; | ||
| result = average; | ||
| average | ||
| }); | ||
| result |
Contributor
There was a problem hiding this comment.
Suggested change
| let mut result = f64::NAN; | |
| self.average | |
| .fetch_update(Ordering::Relaxed, Ordering::Relaxed, |current| { | |
| let average = if current.is_nan() { | |
| point | |
| } else { | |
| point.mul_add(self.alpha, current * (1.0 - self.alpha)) | |
| }; | |
| result = average; | |
| average | |
| }); | |
| result | |
| self.average | |
| .fetch_update(Ordering::Relaxed, Ordering::Relaxed, |current| { | |
| if current.is_nan() { | |
| point | |
| } else { | |
| point.mul_add(self.alpha, current * (1.0 - self.alpha)) | |
| } | |
| }) |
I think this would work the same as fetch_update returns an f64
Member
Author
There was a problem hiding this comment.
The issue is that fetch_update returns the old value (hence the mnemonics of fetch-then-update), but we want to return the updated average which is only accessible in the closure or by adding another fetch which adds to the expense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The source and transform buffer utilization metrics currently measure either the
instantaneous level or a histogram, neither of which is a reliable single-valued
reflection of the actual status. For this purpose, we introduce a
meanmetricthat uses the EWMA calculations to produce a simple moving average that will
better track the actual value.
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.